Attention is currently required from: Thomas Heijligen, Edward O'Callaghan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74065 )
Change subject: util/flashchips_db_jsoniser: Initial version
......................................................................
Patch Set 1:
(1 comment)
File util/flashchips_db_jsoniser/main.c:
https://review.coreboot.org/c/flashrom/+/74065/comment/2303093a_53b419d1
PS1, Line 69: static char *decode_test_state(enum test_state ts)
: {
: switch (ts) {
: case OK: return "OK";
: case NT: return "NT";
: case BAD: return "BAD";
: case DEP: return "DEP";
: case NA: return "NA";
: }
: return NULL;
: };
:
: static char *decode_cmdset(int cmdset)
: {
: switch (cmdset) {
: case SPI25: return "SPI25";
: case SPI_EDI: return "SPI_EDI";
: }
: return NULL;
: }
No. […]
Ack
--
To view, visit
https://review.coreboot.org/c/flashrom/+/74065
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3b65caeb811ec0978091c543ccffb5a1b0d254ba
Gerrit-Change-Number: 74065
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Sam McNally
sammc@google.com
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Comment-Date: Wed, 29 Mar 2023 10:45:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment