[L] Change in flashrom[master]: util/flashchips_db_jsoniser: Initial version

[Edward O'Callaghan (Code Review)]

Attention is currently required from: Thomas Heijligen, Angel Pons.

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74065 )

Change subject: util/flashchips_db_jsoniser: Initial version
......................................................................


Patch Set 1:

(1 comment)

File util/flashchips_db_jsoniser/main.c:

https://review.coreboot.org/c/flashrom/+/74065/comment/352ffa23_d4769747 
PS1, Line 69: static char *decode_test_state(enum test_state ts)
            : {
            :   switch (ts) {
            :     case OK: return "OK";
            :     case NT: return "NT";
            :     case BAD: return "BAD";
            :     case DEP: return "DEP";
            :     case NA: return "NA";
            :   }
            :   return NULL;
            : };
            : 
            : static char *decode_cmdset(int cmdset)
            : {
            :   switch (cmdset) {
            :     case SPI25: return "SPI25";
            :     case SPI_EDI: return "SPI_EDI";
            :   }
            :   return NULL;
            : }
> Ah, so this won't be needed
> No. This specific code is irrelevant for anything more than showing that the array of C struct's into JSON transformation is genuine so the community can audit and modify it until we are happy with the JSON output adequately represents the original with good fidelity.

If you wish you can clang-format it locally for your own readability, but I don't want to break output formatting for no reason.



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/74065
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3b65caeb811ec0978091c543ccffb5a1b0d254ba
Gerrit-Change-Number: 74065
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Thomas Heijligen <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Sam McNally <[e-mail]>
Gerrit-Attention: Thomas Heijligen <[e-mail]>
Gerrit-Attention: Angel Pons <[e-mail]>
Gerrit-Comment-Date: Wed, 29 Mar 2023 10:15:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan <[e-mail]>
Comment-In-Reply-To: Angel Pons <[e-mail]>
Gerrit-MessageType: comment