Attention is currently required from: Thomas Heijligen, Angel Pons.

View Change

1 comment:

• File util/flashchips_db_jsoniser/main.c:

  • Patch Set #1, Line 69:

    static char *decode_test_state(enum test_state ts)
    {
      switch (ts) {
        case OK: return "OK";
        case NT: return "NT";
        case BAD: return "BAD";
        case DEP: return "DEP";
        case NA: return "NA";
      }
      return NULL;
    };
    
    static char *decode_cmdset(int cmdset)
    {
      switch (cmdset) {
        case SPI25: return "SPI25";
        case SPI_EDI: return "SPI_EDI";
      }
      return NULL;
    }
    

    Ah, so this won't be needed

    No. This specific code is irrelevant for anything more than showing that the array of C struct's into JSON transformation is genuine so the community can audit and modify it until we are happy with the JSON output adequately represents the original with good fidelity.

    If you wish you can clang-format it locally for your own readability, but I don't want to break output formatting for no reason.

To view, visit change 74065. To unsubscribe, or for help writing mail filters, visit settings.