Attention is currently required from: qianfan, Nicholas Chin, Angel Pons.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70529 )
Change subject: Add initial CH347T SPI programmer
......................................................................
Patch Set 6:
(1 comment)
File ch347t_spi.c:
https://review.coreboot.org/c/flashrom/+/70529/comment/729a881c_d40791ed
PS5, Line 110: } __attribute__((packed));
It's OK for gcc based compiler. […]
It's not just about the attribute, but the effects of struct packing. On some platforms, unaligned memory accesses will cause problems. This struct might be fine, but `struct ch347_spi_cs_param` has two unaligned 16-bit members.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/70529
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6da5e308af76693e60308c8165349128e517e09a
Gerrit-Change-Number: 70529
Gerrit-PatchSet: 6
Gerrit-Owner: qianfan
qianfanguijin@163.com
Gerrit-Reviewer: Angel Pons
angel.pons@9elements.com
Gerrit-Reviewer: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: qianfan
qianfanguijin@163.com
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Attention: Angel Pons
angel.pons@9elements.com
Gerrit-Comment-Date: Wed, 21 Dec 2022 11:49:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: qianfan
qianfanguijin@163.com
Gerrit-MessageType: comment