Attention is currently required from: qianfan, Nicholas Chin, Angel Pons.

View Change

1 comment:

• File ch347t_spi.c:

  • Patch Set #5, Line 110: } __attribute__((packed));

    It's OK for gcc based compiler. […]

    It's not just about the attribute, but the effects of struct packing. On some platforms, unaligned memory accesses will cause problems. This struct might be fine, but `struct ch347_spi_cs_param` has two unaligned 16-bit members.

To view, visit change 70529. To unsubscribe, or for help writing mail filters, visit settings.