Attention is currently required from: Aarya.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/65642 )
Change subject: flashrom.c:Add function to align region to sector boundaries ......................................................................
Patch Set 58:
(2 comments)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/65642/comment/2d6baeb6_5673e171 PS57, Line 1183: layout[i].layout_list[j]
intermediate to the inner for-loop construct?
for example, something like; ``` for (size_t j = 0; j < layout[i].block_count; j++) { const struct eraseblock_data *ll = &layout[i].layout_list[j];
if (ll->start_addr <= *region_start) start_diff = (*region_start - ll->start_addr) > start_diff ? start_diff : (*region_start - ll->start_addr);
[..] } ```
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/65642/comment/514afdb9_71d5afe1 PS58, Line 1181: int also indexing array's with `unsigned int`