Attention is currently required from: Aarya.

View Change

2 comments:

• File flashrom.c:

  • Patch Set #57, Line 1183: layout[i].layout_list[j]

    intermediate to the inner for-loop construct?

    for example, something like;
    ```
    for (size_t j = 0; j < layout[i].block_count; j++) {
       const struct eraseblock_data *ll = &layout[i].layout_list[j];

       if (ll->start_addr <= *region_start)
         start_diff = (*region_start - ll->start_addr) > start_diff ? start_diff : (*region_start - ll->start_addr);
        
       [..]
    }
    ```

• File flashrom.c:

  • Patch Set #58, Line 1181: int

    also indexing array's with `unsigned int`

To view, visit change 65642. To unsubscribe, or for help writing mail filters, visit settings.