Attention is currently required from: Alan Green. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49632 )
Change subject: ft2232_spi.c: release I/Os on shutdown ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File ft2232_spi.c:
https://review.coreboot.org/c/flashrom/+/49632/comment/05d83332_aa755d0e PS1, Line 175: ret = -8; : goto ftdi_err; : } : : ftdi_err: I feel like this goto makes things more complex then it needs to be for a single branch, the ret of '-8' can also be overwritten with 'f'. Some questions here are, what is '-8' and how about a log line then drop the goto and press on with closing the ftdicontext.
https://review.coreboot.org/c/flashrom/+/49632/comment/96ec232f_597a86ed PS1, Line 183: return f; ret = f; would be consistent with the rest of the control flow.