Attention is currently required from: Alan Green.

Patch set 1:Code-Review +1

View Change

2 comments:

• File ft2232_spi.c:

  • Patch Set #1, Line 175:

    	ret = -8;
    		goto ftdi_err;
    	}
    
    ftdi_err:
    

    I feel like this goto makes things more complex then it needs to be for a single branch, the ret of '-8' can also be overwritten with 'f'. Some questions here are, what is '-8' and how about a log line then drop the goto and press on with closing the ftdicontext.

  • Patch Set #1, Line 183: return f;

    ret = f; would be consistent with the rest of the control flow.

To view, visit change 49632. To unsubscribe, or for help writing mail filters, visit settings.