Change in flashrom[master]: tests: Add unit test to run init/shutdown for mec1308.c, ene_lpc.c

[Nico Huber (Code Review)]

Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Simon Glass.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51487 )

Change subject: tests: Add unit test to run init/shutdown for mec1308.c, ene_lpc.c
......................................................................


Patch Set 10:

(1 comment)

File tests/init_shutdown.c:

https://review.coreboot.org/c/flashrom/+/51487/comment/fefaa940_9eceecb0 
PS10, Line 53: MEC1308_SIO_PORT1
> Yes, that's right...but are we trying to check that the header file has the right constant values? To me a more useful test is that they 'come through' or are dealt with as expected.

I don't know. FWIW, we have not specified what should be tested to
what extend. With wrong numbers, it wouldn't work, I suppose, so
seems worth to test them too?
> If the definitions are considered private, they could go in a header file in the same directory as the driver, perhaps with a _private suffix? Then, just the test can include them

Yeah, that would avoid any confusion with an API.



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/51487
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3af612defe1af3850dfc1626a208d873e3a3eddc
Gerrit-Change-Number: 51487
Gerrit-PatchSet: 10
Gerrit-Owner: Anastasia Klimchuk <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: Nico Huber <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-CC: Simon Glass <[e-mail]>
Gerrit-Attention: Edward O'Callaghan <[e-mail]>
Gerrit-Attention: Angel Pons <[e-mail]>
Gerrit-Attention: Anastasia Klimchuk <[e-mail]>
Gerrit-Attention: Simon Glass <[e-mail]>
Gerrit-Comment-Date: Tue, 04 May 2021 16:39:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <[e-mail]>
Comment-In-Reply-To: Anastasia Klimchuk <[e-mail]>
Comment-In-Reply-To: Simon Glass <[e-mail]>
Gerrit-MessageType: comment