Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Simon Glass.

View Change

1 comment:

• File tests/init_shutdown.c:

  • Patch Set #10, Line 53: MEC1308_SIO_PORT1

    Yes, that's right...but are we trying to check that the header file has the right constant values? To me a more useful test is that they 'come through' or are dealt with as expected.

    I don't know. FWIW, we have not specified what should be tested to
    what extend. With wrong numbers, it wouldn't work, I suppose, so
    seems worth to test them too?

    
    If the definitions are considered private, they could go in a header file in the same directory as the driver, perhaps with a _private suffix? Then, just the test can include them

    Yeah, that would avoid any confusion with an API.

To view, visit change 51487. To unsubscribe, or for help writing mail filters, visit settings.