Attention is currently required from: Anastasia Klimchuk, Peter Marheine.
Simon Arlott has posted comments on this change by Simon Arlott. ( https://review.coreboot.org/c/flashrom/+/86411?usp=email )
Change subject: spidriver: Add support for the Excamera Labs SPIDriver programmer ......................................................................
Patch Set 7:
(3 comments)
File tests/spidriver.c:
https://review.coreboot.org/c/flashrom/+/86411/comment/e49463e4_4beddd5b?usp... : PS7, Line 4: * Copyright 2021 Google LLC
I don't think this line is needed here? I would just leave your name (just line #5). […]
I copied tests/linux_spi.c but have now rewritten almost all of it
https://review.coreboot.org/c/flashrom/+/86411/comment/3354124b_919e7d49?usp... : PS7, Line 83: snprintf((char *)ts->input, sizeof(ts->input), "[spidriver2 AAAAAAAA 000000002 5.190 000 21.9 1 1 1 ffff 0 ]");
This line length goes above our limit (112 chars), but I think if you put arguments on new lines it […]
Done
File tests/tests.c:
https://review.coreboot.org/c/flashrom/+/86411/comment/4974c187_f776cf16?usp... : PS7, Line 27: : struct termios; :
I don't think you need this line here, because `wraps.h` is already included, and wraps. […]
Done