Attention is currently required from: Anastasia Klimchuk, Peter Marheine.

View Change

3 comments:

• File tests/spidriver.c:

  • Patch Set #7, Line 4: * Copyright 2021 Google LLC

    I don't think this line is needed here? I would just leave your name (just line #5). […]

    I copied tests/linux_spi.c but have now rewritten almost all of it

  • Patch Set #7, Line 83: snprintf((char *)ts->input, sizeof(ts->input), "[spidriver2 AAAAAAAA 000000002 5.190 000 21.9 1 1 1 ffff 0 ]");

    This line length goes above our limit (112 chars), but I think if you put arguments on new lines it […]

    Done

• File tests/tests.c:

  • Patch Set #7, Line 27:

    
    struct termios;
    
    

    I don't think you need this line here, because `wraps.h` is already included, and wraps. […]

    Done

To view, visit change 86411. To unsubscribe, or for help writing mail filters, visit settings.