Attention is currently required from: Anastasia Klimchuk, Hsuan-ting Chen, Peter Marheine.
Jakub Czapiga has posted comments on this change by Jakub Czapiga. ( https://review.coreboot.org/c/flashrom/+/83133?usp=email )
Change subject: hwaccess_x86_io: Fix Android compilation with bionic libc ......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/83133/comment/551be1af_560b648d?usp... : PS1, Line 9: Recently Android Bionic LibC got sys/io.h.
The links are non-public, I can't open them from this account.
Sorry, I didn't notice corp proxy in the link. Here are publicly available patches: - [glibc-syscall.h move](https://android-review.googlesource.com/c/platform/bionic/+/221800) - [sys/io.h](https://android-review.googlesource.com/c/platform/bionic/+/3135242)
Android is not mentioned anywhere. It is truly undocumented feature, so I think it's fine to update it.
I'll add this to my list once flashrom is fully accepted as Android external tool (It shouldn't take long) :)
I was thinking to put that "minimum version number" in some doc, but there is no such doc.
C23 has __has_include, but I doubt flashrom will switch to C23 soon to incorporate this. I'll look for ways to check Android version in C #if, so we can cover all major cases with sys/io.h
https://review.coreboot.org/c/flashrom/+/83133/comment/292dc7a5_73fee255?usp... : PS1, Line 12:
Could you please add testing info to commit message? […]
I added testing description. I cannot provide links right now, as flashrom didn't pass Android review yet and thus its mirror is not available in AOSP yet, but I can assure you it works on the latest branch.