Attention is currently required from: Anastasia Klimchuk, Hsuan-ting Chen, Peter Marheine.
2 comments:
Commit Message:
Patch Set #1, Line 9: Recently Android Bionic LibC got sys/io.h.
The links are non-public, I can't open them from this account.
Sorry, I didn't notice corp proxy in the link. Here are publicly available patches:
Android is not mentioned anywhere. It is truly undocumented feature, so I think it's fine to update it.
I'll add this to my list once flashrom is fully accepted as Android external tool (It shouldn't take long) :)
I was thinking to put that "minimum version number" in some doc, but there is no such doc.
C23 has __has_include, but I doubt flashrom will switch to C23 soon to incorporate this. I'll look for ways to check Android version in C #if, so we can cover all major cases with sys/io.h
Could you please add testing info to commit message? […]
I added testing description. I cannot provide links right now, as flashrom didn't pass Android review yet and thus its mirror is not available in AOSP yet, but I can assure you it works on the latest branch.
To view, visit change 83133. To unsubscribe, or for help writing mail filters, visit settings.