Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen, Alexander Goncharov.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68247 )
Change subject: util: add bash completion script ......................................................................
Patch Set 12: Code-Review+2
(3 comments)
Patchset:
PS12: I went through the patch and comments once again, seems like it can go ahead. Sorry Joursoir that it was hanging for so long. Thank you for your work! I will leave it for few days, if everything fine will merge. I understand you are using this feature locally for months already :)
File Makefile:
https://review.coreboot.org/c/flashrom/+/68247/comment/05dce103_c237e464 PS9, Line 1041: .bash
From [Bash Completion FAQ](https://github.com/scop/bash-completion/blob/master/README.md#faq): […]
Okay, so my understanding we have to have a suffix, and the suffix has to be `bash`. Which means leaving as is? and I mark the comment as resolved.
File meson.build:
https://review.coreboot.org/c/flashrom/+/68247/comment/3f54c17a_c2779bd3 PS9, Line 646: .bash
Only option I could find is to provide a custom install_script.
Same situation as with other comment as I understand. Custom install script is probably too much for this... let's leave as is. I am marking as resolved.
-
Anastasia Klimchuk (Code Review)