Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen, Alexander Goncharov.

Patch set 12:Code-Review +2

View Change

3 comments:

• Patchset:

  • Patch Set #12:

    I went through the patch and comments once again, seems like it can go ahead. Sorry Joursoir that it was hanging for so long. Thank you for your work!
    I will leave it for few days, if everything fine will merge. I understand you are using this feature locally for months already :)

• File Makefile:

  • Patch Set #9, Line 1041: .bash

    From [Bash Completion FAQ](https://github.com/scop/bash-completion/blob/master/README.md#faq): […]

    Okay, so my understanding we have to have a suffix, and the suffix has to be `bash`.
    Which means leaving as is? and I mark the comment as resolved.

• File meson.build:

  • Patch Set #9, Line 646: .bash

    Only option I could find is to provide a custom install_script.

    Same situation as with other comment as I understand. Custom install script is probably too much for this... let's leave as is. I am marking as resolved.

To view, visit change 68247. To unsubscribe, or for help writing mail filters, visit settings.