Attention is currently required from: Richard Hughes, Angel Pons, Anastasia Klimchuk, Patrick Rudolph. Daniel Campello has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49643 )
Change subject: libflashrom: Return progress state to the library user ......................................................................
Patch Set 15:
(4 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/49643/comment/40398e22_43418ac3 PS11, Line 15:
Oh sorry for confusion, I didn't mean to write another unit test! I mean test in a literal meaning, […]
Done. Added TEST= field
File include/libflashrom.h:
https://review.coreboot.org/c/flashrom/+/49643/comment/606f8706_576c8097 PS13, Line 113: flashrom_update_progress_callback
Should this also be added in libflashrom. […]
Done
File libflashrom.c:
https://review.coreboot.org/c/flashrom/+/49643/comment/c48baf5a_f1594dbd PS13, Line 106: @param userdata Userdata pointer to include with the progress callback.
This param is now called `progress_state`
Done
https://review.coreboot.org/c/flashrom/+/49643/comment/565a6bcb_ed066e59 PS13, Line 98: /** : * @brief Set the progress callback function. : * : * Set a callback function which will be invoked whenever libflashrom wants : * to indicate the progress has changed. This allows frontends to do whatever : * they see fit with such values, e.g. update a progress bar in a GUI tool. : * : * @param progress_callback Pointer to the new progress callback function. : * @param userdata Userdata pointer to include with the progress callback. : */
Documentation has been moved to header file in CB:63903 , so you will need to rebase and then move t […]
Done
-
Daniel Campello (Code Review)