Attention is currently required from: Richard Hughes, Angel Pons, Anastasia Klimchuk, Patrick Rudolph.

View Change

4 comments:

• Commit Message:

  • Patch Set #11, Line 15:

    Oh sorry for confusion, I didn't mean to write another unit test! I mean test in a literal meaning, […]

    Done. Added TEST= field

• File include/libflashrom.h:

  • Patch Set #13, Line 113: flashrom_update_progress_callback

    Should this also be added in libflashrom. […]

    Done

• File libflashrom.c:

  • Patch Set #13, Line 106: @param userdata Userdata pointer to include with the progress callback.

    This param is now called `progress_state`

    Done

  • Patch Set #13, Line 98:

    /**
     * @brief Set the progress callback function.
     *
     * Set a callback function which will be invoked whenever libflashrom wants
     * to indicate the progress has changed. This allows frontends to do whatever
     * they see fit with such values, e.g. update a progress bar in a GUI tool.
     *
     * @param progress_callback Pointer to the new progress callback function.
     * @param userdata Userdata pointer to include with the progress callback.
     */
    

    Documentation has been moved to header file in CB:63903 , so you will need to rebase and then move t […]

    Done

To view, visit change 49643. To unsubscribe, or for help writing mail filters, visit settings.