Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/46232 )
Change subject: dediprog.c: Fix laying violation of default_spi_read ......................................................................
dediprog.c: Fix laying violation of default_spi_read
default_spi_read() calls spi_read_chunked() with the correct max_read value of 16 set in the spi master struct.
Change-Id: Ic0897f74056e3d723a33c063ed0bd8cb6e88ba45 Signed-off-by: Edward O'Callaghan quasisec@google.com --- M dediprog.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/32/46232/1
diff --git a/dediprog.c b/dediprog.c index 827d5e4..a9d0034 100644 --- a/dediprog.c +++ b/dediprog.c @@ -545,7 +545,7 @@ if (residue) { msg_pdbg("Slow read for partial block from 0x%x, length 0x%x\n", start, residue); - ret = spi_read_chunked(flash, buf, start, residue, 16); + ret = default_spi_read(flash, buf, start, residue); if (ret) goto err; } @@ -560,8 +560,8 @@ if (len != 0) { msg_pdbg("Slow read for partial block from 0x%x, length 0x%x\n", start, len); - ret = spi_read_chunked(flash, buf + residue + bulklen, - start + residue + bulklen, len, 16); + ret = default_spi_read(flash, buf + residue + bulklen, + start + residue + bulklen, len); if (ret) goto err; }
Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46232 )
Change subject: dediprog.c: Fix laying violation of default_spi_read ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46232 )
Change subject: dediprog.c: Fix laying violation of default_spi_read ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/flashrom/+/46232/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/46232/1//COMMIT_MSG@7 PS1, Line 7: laying layering?
Hello Sam McNally, build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/46232
to look at the new patch set (#2).
Change subject: dediprog.c: Fix layering violation of default_spi_read ......................................................................
dediprog.c: Fix layering violation of default_spi_read
default_spi_read() calls spi_read_chunked() with the correct max_read value of 16 set in the spi master struct.
Change-Id: Ic0897f74056e3d723a33c063ed0bd8cb6e88ba45 Signed-off-by: Edward O'Callaghan quasisec@google.com --- M dediprog.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/32/46232/2
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46232 )
Change subject: dediprog.c: Fix layering violation of default_spi_read ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/flashrom/+/46232/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/46232/1//COMMIT_MSG@7 PS1, Line 7: laying
layering?
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46232 )
Change subject: dediprog.c: Fix layering violation of default_spi_read ......................................................................
Patch Set 2: Code-Review+2
Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/46232 )
Change subject: dediprog.c: Fix layering violation of default_spi_read ......................................................................
dediprog.c: Fix layering violation of default_spi_read
default_spi_read() calls spi_read_chunked() with the correct max_read value of 16 set in the spi master struct.
Change-Id: Ic0897f74056e3d723a33c063ed0bd8cb6e88ba45 Signed-off-by: Edward O'Callaghan quasisec@google.com Reviewed-on: https://review.coreboot.org/c/flashrom/+/46232 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Sam McNally sammc@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M dediprog.c 1 file changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Sam McNally: Looks good to me, approved
diff --git a/dediprog.c b/dediprog.c index 827d5e4..a9d0034 100644 --- a/dediprog.c +++ b/dediprog.c @@ -545,7 +545,7 @@ if (residue) { msg_pdbg("Slow read for partial block from 0x%x, length 0x%x\n", start, residue); - ret = spi_read_chunked(flash, buf, start, residue, 16); + ret = default_spi_read(flash, buf, start, residue); if (ret) goto err; } @@ -560,8 +560,8 @@ if (len != 0) { msg_pdbg("Slow read for partial block from 0x%x, length 0x%x\n", start, len); - ret = spi_read_chunked(flash, buf + residue + bulklen, - start + residue + bulklen, len, 16); + ret = default_spi_read(flash, buf + residue + bulklen, + start + residue + bulklen, len); if (ret) goto err; }
-
Angel Pons (Code Review) -
Edward O'Callaghan (Code Review)
-
Sam McNally (Code Review)