Edward O'Callaghan submitted this change.
dediprog.c: Fix layering violation of default_spi_read
default_spi_read() calls spi_read_chunked() with the correct
max_read value of 16 set in the spi master struct.
Change-Id: Ic0897f74056e3d723a33c063ed0bd8cb6e88ba45
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/46232
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Sam McNally <sammc@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M dediprog.c
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/dediprog.c b/dediprog.c
index 827d5e4..a9d0034 100644
--- a/dediprog.c
+++ b/dediprog.c
@@ -545,7 +545,7 @@
if (residue) {
msg_pdbg("Slow read for partial block from 0x%x, length 0x%x\n",
start, residue);
- ret = spi_read_chunked(flash, buf, start, residue, 16);
+ ret = default_spi_read(flash, buf, start, residue);
if (ret)
goto err;
}
@@ -560,8 +560,8 @@
if (len != 0) {
msg_pdbg("Slow read for partial block from 0x%x, length 0x%x\n",
start, len);
- ret = spi_read_chunked(flash, buf + residue + bulklen,
- start + residue + bulklen, len, 16);
+ ret = default_spi_read(flash, buf + residue + bulklen,
+ start + residue + bulklen, len);
if (ret)
goto err;
}
To view, visit change 46232. To unsubscribe, or for help writing mail filters, visit settings.