Change in flashrom[master]: dediprog: Fix SF600 4BA mode

List overview All Threads
Download

newer

older

Change in flashrom[master]:...

[XS] Change in flashrom[main]:...

Patrick Rudolph (Code Review)

30 Jul 2019 30 Jul '19

3:49 p.m.

Hello Patrick Rudolph,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/flashrom/+/34629

to review the following change.

Change subject: dediprog: Fix SF600 4BA mode ......................................................................

dediprog: Fix SF600 4BA mode

Flash chips greater than 16MiB require 4BA mode support. Current master doesn't support such mode as the SF600 uses PROTOCOL_V3.

Fix protocol version check to support 4BA on PROTOCOL_V3, too.

Tested on SF600 V:7.2.45 Able to read and write "IS25WP256" (32768 kB, SPI).

Change-Id: I2d3089693fbd2f8f7717a8f71be242be131ce707 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M dediprog.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/29/34629/1

diff --git a/dediprog.c b/dediprog.c index 3566109..add478d 100644 --- a/dediprog.c +++ b/dediprog.c @@ -1160,7 +1160,7 @@ if (dediprog_devicetype == DEV_SF100 && protocol() == PROTOCOL_V1) spi_master_dediprog.features &= ~SPI_MASTER_NO_4BA_MODES;

- if (protocol() == PROTOCOL_V2) + if (protocol() >= PROTOCOL_V2) spi_master_dediprog.features |= SPI_MASTER_4BA;

if (register_spi_master(&spi_master_dediprog) || dediprog_set_leds(LED_NONE))

Attachments:

attachment.htm (text/html — 2.8 KB)

Show replies by date

Angel Pons (Code Review)

30 Jul 30 Jul

4:38 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34629 )

Change subject: dediprog: Fix SF600 4BA mode ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/flashrom/+/34629 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2d3089693fbd2f8f7717a8f71be242be131ce707 Gerrit-Change-Number: 34629 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 30 Jul 2019 14:38:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

David Hendricks (Code Review)

31 Jul 31 Jul

5:01 a.m.

David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34629 )

Change subject: dediprog: Fix SF600 4BA mode ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/flashrom/+/34629 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2d3089693fbd2f8f7717a8f71be242be131ce707 Gerrit-Change-Number: 34629 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 31 Jul 2019 03:01:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

7:59 a.m.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34629 )

Change subject: dediprog: Fix SF600 4BA mode ......................................................................

Patch Set 1: Code-Review-1

I'm getting 'flash erasure failure' when using this patch. Not sure if it's related to the 4BA mode or something else. Needs more tests.

-- To view, visit https://review.coreboot.org/c/flashrom/+/34629 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2d3089693fbd2f8f7717a8f71be242be131ce707 Gerrit-Change-Number: 34629 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 31 Jul 2019 05:59:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

10:04 a.m.

Hello Angel Pons, Patrick Rudolph, David Hendricks, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/flashrom/+/34629

to look at the new patch set (#2).

Change subject: dediprog: Fix SF600 4BA mode ......................................................................

dediprog: Fix SF600 4BA mode

Flash chips greater than 16MiB require 4BA mode support. Current master doesn't support such mode as the SF600 uses PROTOCOL_V3.

Fix protocol version check to support 4BA on PROTOCOL_V3, and use different read/write commands.

Tested on SF600 V:7.2.45 Able to read and write "IS25WP256" (32768 kB, SPI).

Change-Id: I2d3089693fbd2f8f7717a8f71be242be131ce707 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M dediprog.c 1 file changed, 8 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/29/34629/2

-- To view, visit https://review.coreboot.org/c/flashrom/+/34629 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2d3089693fbd2f8f7717a8f71be242be131ce707 Gerrit-Change-Number: 34629 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Patrick Rudolph (Code Review)

10:19 a.m.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34629 )

Change subject: dediprog: Fix SF600 4BA mode ......................................................................

Patch Set 2: Code-Review-1

It worked only *once* to flash the full IC. Using a different ROM it's broken again. Looks like it takes a different code path. Needs further investigation.

-- To view, visit https://review.coreboot.org/c/flashrom/+/34629 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2d3089693fbd2f8f7717a8f71be242be131ce707 Gerrit-Change-Number: 34629 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 31 Jul 2019 08:19:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

11 Aug 11 Aug

9:09 a.m.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34629 )

Change subject: dediprog: Fix SF600 4BA mode ......................................................................

Patch Set 2:

Tested with SF600 and MX66L51235F. Can erase, read and write the whole chip with this patch.

-- To view, visit https://review.coreboot.org/c/flashrom/+/34629 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2d3089693fbd2f8f7717a8f71be242be131ce707 Gerrit-Change-Number: 34629 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 11 Aug 2020 07:09:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Anastasia Klimchuk (Code Review)

25 Nov 25 Nov

1:37 p.m.

New subject: [XS] Change in flashrom[main]: dediprog: Fix SF600 4BA mode

Attention is currently required from: Patrick Rudolph.

Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34629?usp=email )

Change subject: dediprog: Fix SF600 4BA mode ......................................................................

Patch Set 2:

(1 comment)

Patchset:

PS2: Hello Patrick! I haven't looked closely at this patch, but what is the current state of it, are you still interested in the patch, is it relevant? I can see the last action was in 2020, but it's very possible it's still relevant and valid patch. Are you interested to complete it?

-- To view, visit https://review.coreboot.org/c/flashrom/+/34629?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I2d3089693fbd2f8f7717a8f71be242be131ce707 Gerrit-Change-Number: 34629 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph rudolphpatrick05@gmail.com Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Anastasia Klimchuk aklm@chromium.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Attention: Patrick Rudolph rudolphpatrick05@gmail.com Gerrit-Comment-Date: Sat, 25 Nov 2023 12:37:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

392

days inactive

1971

days old

flashrom-gerrit@flashrom.org

7 comments

4 participants

tags (0)

participants (4)

Anastasia Klimchuk (Code Review)
Angel Pons (Code Review)
David Hendricks (Code Review)
Patrick Rudolph (Code Review)