[XS] Change in flashrom[main]: Makefile: CONFIG_INTERNAL depends on raw mem access
Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Thomas Heijligen. Fabrice Fontaine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/78930?usp=email ) Change subject: Makefile: CONFIG_INTERNAL depends on raw mem access ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/78930/comment/2864508b_6ab47692 : PS1, Line 17:
If you could add here in commit message testing info (which environment with which exactly options y […] Done
Patchset: PS1:
I opened the link from commit message, flashrom is build with the following: […] We're not using meson.build to compile flashrom in buildroot but indeed it seems all good.
-- To view, visit https://review.coreboot.org/c/flashrom/+/78930?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I7610f5f7cc5b114ffa90d5752155acc8b6b7c9f7 Gerrit-Change-Number: 78930 Gerrit-PatchSet: 2 Gerrit-Owner: Fabrice Fontaine <fontaine.fabrice@gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Reviewer: Thomas Heijligen <src@posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Alexander Goncharov <chat@joursoir.net> Gerrit-Attention: Thomas Heijligen <src@posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Attention: Alexander Goncharov <chat@joursoir.net> Gerrit-Comment-Date: Sat, 25 Nov 2023 11:34:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org> Comment-In-Reply-To: Alexander Goncharov <chat@joursoir.net> Gerrit-MessageType: comment
participants (1)
-
Fabrice Fontaine (Code Review)