[M] Change in flashrom[master]: flashrom: Skip read/write/erase/verify ops on inaccessable flash regions
Attention is currently required from: Edward O'Callaghan, Angel Pons.
Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70128 )
Change subject: flashrom: Skip read/write/erase/verify ops on inaccessable flash regions ......................................................................
Patch Set 13:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/70128/comment/e9c53620_6b7a86e7 PS6, Line 11: platforms with active an CSME coprocessor.
Would it help to split this up into read/write/erase/verify ops? I feel like 'erase' and 'read' are […]
Ack, we can handle the cases differently. For consistency maybe erase should just use the same flag as write though.
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/70128/comment/ab127022_c37aa188 PS13, Line 348: region->name = strdup("");
can `region->name` not be NULL and treat that as the empty string?
Yeah but we still have the case where ichspi allocates strings as well. Maybe we can drop that too but I'd prefer to find a better solution if possible.
https://review.coreboot.org/c/flashrom/+/70128/comment/e9637f60_c271471e PS13, Line 579: i
use `addr` not `i`, it is more descriptive, index is prone to error.
Done
-
Nikolai Artemiev (Code Review)