Attention is currently required from: Edward O'Callaghan, Angel Pons.
3 comments:
Commit Message:
Patch Set #6, Line 11: platforms with active an CSME coprocessor.
Would it help to split this up into read/write/erase/verify ops? I feel like 'erase' and 'read' are […]
Ack, we can handle the cases differently. For consistency maybe erase should just use the same flag as write though.
File flashrom.c:
Patch Set #13, Line 348: region->name = strdup("");
can `region->name` not be NULL and treat that as the empty string?
Yeah but we still have the case where ichspi allocates strings as well. Maybe we can drop that too but I'd prefer to find a better solution if possible.
use `addr` not `i`, it is more descriptive, index is prone to error.
Done
To view, visit change 70128. To unsubscribe, or for help writing mail filters, visit settings.