Attention is currently required from: Nico Huber, Thomas Heijligen, Edward O'Callaghan. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55295 )
Change subject: tests: Do not run a test if its driver is not built ......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/55295/comment/a70b3378_b3988c38 PS5, Line 10: however config options can be disabled and in that case test should : not be run.
As we discussed today; […]
Thank you! Yes, I understand. As much as I enjoyed writing this patch, but I understand that avoiding pre-processor conditionals at all is always better.
The only thing I am thinking about, this will take me some time to make it work, meanwhile tests can break when defaults change. Specifically, if someone wants to build and run tests with CONFIG_MEC1308=no that won't be possible. I don't know if anyone needs to run tests with CONFIG_MEC1308=no (myself not counted :)).
-
Anastasia Klimchuk (Code Review)