Attention is currently required from: Nico Huber, Thomas Heijligen, Edward O'Callaghan.

View Change

1 comment:

• Commit Message:

  • Patch Set #5, Line 10:

    however config options can be disabled and in that case test should
    not be run.
    

    As we discussed today; […]

    Thank you! Yes, I understand. As much as I enjoyed writing this patch, but I understand that avoiding pre-processor conditionals at all is always better.

    The only thing I am thinking about, this will take me some time to make it work, meanwhile tests can break when defaults change. Specifically, if someone wants to build and run tests with CONFIG_MEC1308=no that won't be possible. I don't know if anyone needs to run tests with CONFIG_MEC1308=no (myself not counted :)).

To view, visit change 55295. To unsubscribe, or for help writing mail filters, visit settings.