Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer.
Eric Park has posted comments on this change by Eric Park. ( https://review.coreboot.org/c/flashrom/+/86990?usp=email )
Change subject: flashchips: Add XMC XM25QH64A ......................................................................
Patch Set 7: -Code-Review
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/86990/comment/5f34d22f_e0885938?usp... : PS6, Line 14:
I forgot to ask: would you please add link to datasheet in commit message? […]
Done! I stole your datasheet URL :)
File flashchips/xmc.c:
https://review.coreboot.org/c/flashrom/+/86990/comment/f11a6508_bb953f99?usp... : PS6, Line 337: TEST_OK_PREW
Based on what you explained in the other comment (about testing), the test status should be `TEST_OK […]
I can test wiping the chip that I have and rewriting with the bin I pulled off originally; can we leave it at TEST_OK_PREW in that case or is more testing required? I will post another comment once this is done.
-
Eric Park (Code Review)