Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer.
Patch set 7:-Code-Review
View Change
2 comments:
Commit Message:
File flashchips/xmc.c:
Patch Set #6, Line 337: TEST_OK_PREW
Based on what you explained in the other comment (about testing), the test status should be `TEST_OK […]
I can test wiping the chip that I have and rewriting with the bin I pulled off originally; can we leave it at TEST_OK_PREW in that case or is more testing required? I will post another comment once this is done.
To view, visit change 86990. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I5b11e30f0a5357a6cbb32ddb93f450de5364c60b
Gerrit-Change-Number: 86990
Gerrit-PatchSet: 7
Gerrit-Owner: Eric Park <me@ericswpark.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Eric Park <me@ericswpark.com>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Comment-Date: Wed, 26 Mar 2025 15:04:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>