Attention is currently required from: Subrata Banik, Angel Pons, Anastasia Klimchuk.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62894 )
Change subject: ichspi: Rename HSFC FDBC offset macros
......................................................................
Patch Set 8:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62894/comment/c926c1a4_8e022d39
PS6, Line 10: during the data portion of the SPI cycle.
My understanding is that renaming is needed for the next patch CB:62892 which introduces `HSFC_FDBC(n)`. Subrata please correct me if I am wrong?
Only because the next patch provokes a name conflict. And only
for `HSFC_FDBC -> HSFC_FDBC_MASK`, and not for the `_OFF` macro.
`HSFC_FDBC_OFF` is the correct name anyway, and probably only
changed to keep it pprint_reg() compatible. But then it's incon-
sistent with all the other `_OFF` macro names... It seems the only
winning move is not to play. How about naming the new macro diffe-
rently, e.g. `HSFC_FDBC_VAL(n)`?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/62894
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia0ae9a586b5c12f0229334898426175ec246a70c
Gerrit-Change-Number: 62894
Gerrit-PatchSet: 8
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Subrata Banik
subi.banik@gmail.com
Gerrit-Attention: Subrata Banik
subi.banik@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Wed, 13 Apr 2022 17:16:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment