Attention is currently required from: Subrata Banik, Angel Pons, Anastasia Klimchuk.

View Change

1 comment:

• Commit Message:

  • Patch Set #6, Line 10: during the data portion of the SPI cycle.

    My understanding is that renaming is needed for the next patch CB:62892 which introduces `HSFC_FDBC(n)`. Subrata please correct me if I am wrong?

    Only because the next patch provokes a name conflict. And only
    for `HSFC_FDBC -> HSFC_FDBC_MASK`, and not for the `_OFF` macro.
    `HSFC_FDBC_OFF` is the correct name anyway, and probably only
    changed to keep it pprint_reg() compatible. But then it's incon-
    sistent with all the other `_OFF` macro names... It seems the only
    winning move is not to play. How about naming the new macro diffe-
    rently, e.g. `HSFC_FDBC_VAL(n)`?

To view, visit change 62894. To unsubscribe, or for help writing mail filters, visit settings.