Change in flashrom[master]: [RFC] writeprotect: implement wp_{get,set}_range()

[Nikolai Artemiev (Code Review)]

Attention is currently required from: Nico Huber.
Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58482 )

Change subject: [RFC] writeprotect: implement wp_{get,set}_range()
......................................................................


Patch Set 6:

(1 comment)

Patchset:

PS6:
> I guess a separate tool that handles only block protection (or write > protection or flash configuration in general) would be much easier to maintain.

I think you mean building a separate binary from common sources right? Splitting off an entirely separate project would be a lot of extra work, especially when read/write/erase operations need some of the same functionality (i.e. disabling block protection).

I'm fine with building a separate binary, though I think we would need to be careful about how we partition the functionality to avoid feature duplication.
> I would much prefer to only call libflashrom functions from any CLI code.

I agree, I definitely want to move the writeprotect interface into libflashrom. I thought it would be easier to call the functions directly for now, but it shouldn't take too much work to squash writeprotect.h into libflashrom.h.



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/58482
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7d26f43fb05c5828b9839bb57a28fa1088dcd9a0
Gerrit-Change-Number: 58482
Gerrit-PatchSet: 6
Gerrit-Owner: Nikolai Artemiev <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Nico Huber <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Attention: Nico Huber <[e-mail]>
Gerrit-Comment-Date: Mon, 01 Nov 2021 10:24:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <[e-mail]>
Gerrit-MessageType: comment