Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56721 )
Change subject: internal: Return early from map_flash for >16MiB on x86 ......................................................................
Patch Set 3: Code-Review-1
(4 comments)
Patchset:
PS1:
just noticed this comment. […]
Well, the Promontory support there looks like a WIP hack to me. For instance, how should we support >16MiB chips there? The commit message doesn't seem to mention why the memory mapping is used.
Patchset:
PS3:
Could this get merged?
IMHO, fixing the calls is still a much better solution.
File physmap.c:
https://review.coreboot.org/c/flashrom/+/56721/comment/6f39dd35_e3938237 PS3, Line 264: #if IS_X86 It shouldn't be necessary to use a preprocessor guard. Also, what you probably intend to check is if an internal programmer targeting the BIOS chip on x86 is used. If another programmer is used, the host architecture shouldn't matter.
https://review.coreboot.org/c/flashrom/+/56721/comment/e26e4b89_cc37203a PS3, Line 268: c `c` is for chip, while this is programmer code `p`.