Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Anastasia Klimchuk.

Patch set 3:Code-Review -1

View Change

4 comments:

• Patchset:

  • Patch Set #1:

    just noticed this comment. […]

    Well, the Promontory support there looks like a WIP hack to me. For instance,
    how should we support >16MiB chips there? The commit message doesn't seem
    to mention why the memory mapping is used.

• Patchset:

  • Patch Set #3:

    Could this get merged?

    IMHO, fixing the calls is still a much better solution.

• File physmap.c:

  • Patch Set #3, Line 264: #if IS_X86

    It shouldn't be necessary to use a preprocessor guard. Also, what you
    probably intend to check is if an internal programmer targeting the
    BIOS chip on x86 is used. If another programmer is used, the host
    architecture shouldn't matter.

  • Patch Set #3, Line 268: c

    `c` is for chip, while this is programmer code `p`.

To view, visit change 56721. To unsubscribe, or for help writing mail filters, visit settings.