Attention is currently required from: Nico Huber, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56414 )
Change subject: dediprog.c: Refactor singleton states into reentrant pattern ......................................................................
Patch Set 5:
(1 comment)
File dediprog.c:
https://review.coreboot.org/c/flashrom/+/56414/comment/f68abb50_bf72d8ab PS3, Line 221: const int finish,
I don't think there is a written rule. There are three common ways […]
I made one more patchset, these three functions now look consistent: dediprog_bulk_read_poll dediprog_read dediprog_write For some reason I thought I can only use tabs, no spaces! With spaces it looks better.
There are 5 other occurrences where a function call (not declaration) gets too long and arguments list needs to be split, which introduces extra line. But all those 5 places are returned back in the next patch, after removing prefix extra line not needed anymore.