Attention is currently required from: Nico Huber, Angel Pons.
View Change
1 comment:
File dediprog.c:
Patch Set #3, Line 221: const int finish,
I don't think there is a written rule. There are three common ways […]
I made one more patchset, these three functions now look consistent:
dediprog_bulk_read_poll
dediprog_read
dediprog_write
For some reason I thought I can only use tabs, no spaces! With spaces it looks better.
There are 5 other occurrences where a function call (not declaration) gets too long and arguments list needs to be split, which introduces extra line. But all those 5 places are returned back in the next patch, after removing prefix extra line not needed anymore.
To view, visit change 56414. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I72085e750af97b94dfa94f2ebf2a134e41a2ec8d
Gerrit-Change-Number: 56414
Gerrit-PatchSet: 5
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Mon, 13 Sep 2021 03:26:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-MessageType: comment