Attention is currently required from: Felix Singer, Thomas Heijligen, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Peter Marheine.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67649 )
Change subject: flashrom.c: Drop `programmer_param` global variable
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Patchset:
PS1:
Not sure if anybody checked that there is no NULL pointer introduced
on any call path that leads to extract_programmer_param_str().
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/67649/comment/8c02dca8_e9e8a9ea
PS1, Line 297: &
That this is a pointer inside a const struct and works made me realize
how odd the extract_param() signature is. We pass a pointer to a char
pointer that gets never changed, so we could as well pass the char pointer
directly.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/67649
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I59397451ea625bd431b15848bad5ec7cb926f22d
Gerrit-Change-Number: 67649
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Comment-Date: Wed, 14 Sep 2022 14:12:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment