Attention is currently required from: Felix Singer, Thomas Heijligen, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Peter Marheine.

Patch set 1:Code-Review +1

View Change

2 comments:

• Patchset:

  • Patch Set #1:

    Not sure if anybody checked that there is no NULL pointer introduced
    on any call path that leads to extract_programmer_param_str().

• File flashrom.c:

  • Patch Set #1, Line 297: &

    That this is a pointer inside a const struct and works made me realize
    how odd the extract_param() signature is. We pass a pointer to a char
    pointer that gets never changed, so we could as well pass the char pointer
    directly.

To view, visit change 67649. To unsubscribe, or for help writing mail filters, visit settings.