Change in flashrom[master]: jlink_spi.c: Refactor singleton states into reentrant pattern - flashrom-gerrit

21 Apr 2021


      Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52560 )
Change subject: jlink_spi.c: Refactor singleton states into reentrant pattern
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1: 
Thanks people for reviews, I will address the comment(s) in the next patch.
If anyone can submit this, it would be great!
File jlink_spi.c:
https://review.coreboot.org/c/flashrom/+/52560/comment/e611706b_7adeb0bd 
PS1, Line 55: jaylink_c
...
I'd move the `jaylink` part to the variable name, maybe shorten it to `jlink`. For example: […]
Sure, I will do the next patch for renaming.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/52560
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If13ad0c979ccf62ca4ccbd479d471c657895ef59
Gerrit-Change-Number: 52560
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Miklós Márton martonmiklosqdev@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Sam McNally sammc@google.com
Gerrit-Comment-Date: Wed, 21 Apr 2021 21:20:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment