View Change
2 comments:
Patchset:
File jlink_spi.c:
Patch Set #1, Line 55: jaylink_c
I'd move the `jaylink` part to the variable name, maybe shorten it to `jlink`. For example: […]
Sure, I will do the next patch for renaming.
To view, visit change 52560. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If13ad0c979ccf62ca4ccbd479d471c657895ef59
Gerrit-Change-Number: 52560
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Miklós Márton <martonmiklosqdev@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-CC: Sam McNally <sammc@google.com>
Gerrit-Comment-Date: Wed, 21 Apr 2021 21:20:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment