Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk, Nikolai Artemiev.
Liam Flaherty has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68364 )
Change subject: debug_raiden_spi: Remove fixme with explanation ......................................................................
Patch Set 1:
(1 comment)
File raiden_debug_spi.c:
https://review.coreboot.org/c/flashrom/+/68364/comment/c61c7680_d3df8e7e PS1, Line 354: // rather than looking for a device with a specific vid:pid. I have two thoughts on how to address the FIXME. 1. Leave the code as is and simply leave the dev_entry table empty with a comment, as it appears here. 2. Populate the `revs_raiden` table to include all of the vid:pid pairs for all the devices that use this programmer. This would also involve a change to the `raiden_debug_spi_init` method to read this table rather than the current matching logic.
Thoughts?