Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk, Nikolai Artemiev.
View Change
1 comment:
File raiden_debug_spi.c:
Patch Set #1, Line 354: // rather than looking for a device with a specific vid:pid.
I have two thoughts on how to address the FIXME.
1. Leave the code as is and simply leave the dev_entry table empty with a comment, as it appears here.
2. Populate the `revs_raiden` table to include all of the vid:pid pairs for all the devices that use this programmer. This would also involve a change to the `raiden_debug_spi_init` method to read this table rather than the current matching logic.
Thoughts?
To view, visit change 68364. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I43e364c02f42dd499d3c9ca3e0a03ead673da3e6
Gerrit-Change-Number: 68364
Gerrit-PatchSet: 1
Gerrit-Owner: Liam Flaherty <liamflaherty@chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Comment-Date: Thu, 13 Oct 2022 02:04:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment