Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer.
Alexandru Stan has posted comments on this change by Alexandru Stan. ( https://review.coreboot.org/c/flashrom/+/84752?usp=email )
Change subject: flashchips: add Winbond W25R512NW / W74M51NW ......................................................................
Patch Set 2:
(6 comments)
Patchset:
PS2: PTAL.
I'm pretty sure I successfully confirmed every other `.property =` that I did not comment about already with the datasheet.
Commit Message:
https://review.coreboot.org/c/flashrom/+/84752/comment/758ce844_3b56fa42?usp... : PS1, Line 8: : I don't actually have a datasheet for this (so feel free to reject this : CL)
Thank you for contribution! No I won't reject it so easily, my first reaction is to try and find the […]
Still working on this, I just got a datasheet myself, but not sure how distributable it is (since I'm not Winbond), asking around for now (could you check your gdrive perhaps ;) but 64MB might be a little big for chromeos).
https://review.coreboot.org/c/flashrom/+/84752/comment/205d28bc_f9fb6ba2?usp... : PS1, Line 10: I just bruteforced it
This is so cool! :)
Yay, the datasheet (that I just internally aquired) confirms my work!
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/84752/comment/990f97c0_f49ef469?usp... : PS1, Line 20271: 1650 Datasheet disagreed here.
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/84752/comment/d023e13c_dd2e7af4?usp... : PS2, Line 20239: 1024B total, 256B reserved Again, copied this comment from that Winbond chip. From the datasheet it's worded differently (3* 256B), but maybe the same?
https://review.coreboot.org/c/flashrom/+/84752/comment/0a08bcb9_9e9bfd07?usp... : PS2, Line 20269: .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_BP3_SRWD, : .unlock = SPI_DISABLE_BLOCKPROTECT, : Given I haven't tested WP, I don't know if these are good. I copied the other chip's definition which has the same thing. Someone better at testing this should confirm. Though given `.tested = TEST_OK_PREW,` maybe this is ok enough?