Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer.
6 comments:
Patchset:
PTAL.
I'm pretty sure I successfully confirmed every other `.property =` that I did not comment about already with the datasheet.
Commit Message:
I don't actually have a datasheet for this (so feel free to reject this
CL)
Thank you for contribution! No I won't reject it so easily, my first reaction is to try and find the […]
Still working on this, I just got a datasheet myself, but not sure how distributable it is (since I'm not Winbond), asking around for now (could you check your gdrive perhaps ;) but 64MB might be a little big for chromeos).
Patch Set #1, Line 10: I just bruteforced it
This is so cool! :)
Yay, the datasheet (that I just internally aquired) confirms my work!
File flashchips.c:
Patch Set #1, Line 20271: 1650
Datasheet disagreed here.
File flashchips.c:
Patch Set #2, Line 20239: 1024B total, 256B reserved
Again, copied this comment from that Winbond chip. From the datasheet it's worded differently (3* 256B), but maybe the same?
.printlock = SPI_PRETTYPRINT_STATUS_REGISTER_BP3_SRWD,
.unlock = SPI_DISABLE_BLOCKPROTECT,
Given I haven't tested WP, I don't know if these are good. I copied the other chip's definition which has the same thing. Someone better at testing this should confirm. Though given `.tested = TEST_OK_PREW,` maybe this is ok enough?
To view, visit change 84752. To unsubscribe, or for help writing mail filters, visit settings.