Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48949 )
Change subject: flashchips.c: Add support for XMC new spi flash types ......................................................................
Patch Set 1: Code-Review+1
(8 comments)
Thank you for the patch. Please see comments inline for some minor issues.
https://review.coreboot.org/c/flashrom/+/48949/1/flashchips.h File flashchips.h:
https://review.coreboot.org/c/flashrom/+/48949/1/flashchips.h@814 PS1, Line 814: two tabs needed to line up with the rest from the looks of it.
https://review.coreboot.org/c/flashrom/+/48949/1/flashchips.c File flashchips.c:
https://review.coreboot.org/c/flashrom/+/48949/1/flashchips.c@18994 PS1, Line 18994: spurious tab, delete.
https://review.coreboot.org/c/flashrom/+/48949/1/flashchips.c@19004 PS1, Line 19004: TEST_OK_PREW Were these all tested? if not then you want `TEST_UNTESTED`. The meaning of these are defined in flash.h just for your information.
If they were indeed tested please update the commit message with a TEST=test ran line to indicate how.
https://review.coreboot.org/c/flashrom/+/48949/1/flashchips.c@19070 PS1, Line 19070: spurious tab, delete.
https://review.coreboot.org/c/flashrom/+/48949/1/flashchips.c@19148 PS1, Line 19148: spurious tab, delete.
https://review.coreboot.org/c/flashrom/+/48949/1/flashchips.c@19149 PS1, Line 19149: { too many braces, delete this one.
https://review.coreboot.org/c/flashrom/+/48949/1/flashchips.c@19150 PS1, Line 19150: spurious tab, delete.
https://review.coreboot.org/c/flashrom/+/48949/1/flashchips.c@19192 PS1, Line 19192: spurious tab, delete.
-
Edward O'Callaghan (Code Review)