Thank you for the patch. Please see comments inline for some minor issues.

Patch set 1:Code-Review +1

View Change

8 comments:

• File flashchips.h:

  • Patch Set #1, Line 814:

    two tabs needed to line up with the rest from the looks of it.

• File flashchips.c:

  • Patch Set #1, Line 18994:

    spurious tab, delete.

  • Patch Set #1, Line 19004: TEST_OK_PREW

    Were these all tested? if not then you want `TEST_UNTESTED`. The meaning of these are defined in flash.h just for your information.

    If they were indeed tested please update the commit message with a TEST=test ran line to indicate how.

  • Patch Set #1, Line 19070:

    spurious tab, delete.

  • Patch Set #1, Line 19148:

    spurious tab, delete.

  • Patch Set #1, Line 19149: {

    too many braces, delete this one.

  • Patch Set #1, Line 19150:

    spurious tab, delete.

  • Patch Set #1, Line 19192:

    spurious tab, delete.

To view, visit change 48949. To unsubscribe, or for help writing mail filters, visit settings.