Change in flashrom[master]: pony_spi.c: Fix memory leak in function pony_init_spi

[Martin L Roth (Code Review)]

Attention is currently required from: Felix Singer, Nico Huber, Paul Menzel, Angel Pons, Light, Anastasia Klimchuk.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62724 )

Change subject: pony_spi.c: Fix memory leak in function pony_init_spi
......................................................................

Patch Set 6:

(1 comment)

Patchset:

PS5:
> > Could we make it comments like with checkpatch in coreboot? […]

I can take a look at having it give checkpatch-like comments, but since it scans the entire build, not just the patch the way checkpatch does, I think we'd still need to deal with false positives.  We might be able to deal with them by post-processing the scan-build output, but that's probably more long-term

Here's what the Clang project says about it:
https://clang-analyzer.llvm.org/faq.html

We can also disable classes of build errors.

It takes roughly an extra 60 to 90 seconds per build to do the scan.  This could be sped up very significantly if we didn't compile with a single thread in test_build.sh.