Attention is currently required from: Felix Singer, Nico Huber, Paul Menzel, Angel Pons, Light, Anastasia Klimchuk.
View Change
1 comment:
Patchset:
Patch Set #5:
> Could we make it comments like with checkpatch in coreboot? […]
I can take a look at having it give checkpatch-like comments, but since it scans the entire build, not just the patch the way checkpatch does, I think we'd still need to deal with false positives. We might be able to deal with them by post-processing the scan-build output, but that's probably more long-term
Here's what the Clang project says about it:
https://clang-analyzer.llvm.org/faq.html
We can also disable classes of build errors.
It takes roughly an extra 60 to 90 seconds per build to do the scan. This could be sped up very significantly if we didn't compile with a single thread in test_build.sh.
To view, visit change 62724. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7910db94f63693e7f131836d4963e88cfdbec301
Gerrit-Change-Number: 62724
Gerrit-PatchSet: 6
Gerrit-Owner: Light <aarya.chaumal@gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Felix Singer <felixsinger@posteo.net>
Gerrit-CC: Martin L Roth <martinroth@google.com>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Light <aarya.chaumal@gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Comment-Date: Sat, 12 Mar 2022 20:49:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger@posteo.net>
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Martin L Roth <martinroth@google.com>
Gerrit-MessageType: comment