[M] Change in flashrom[main]: libflashrom: Add probing v2 which can find all mathching chips
Attention is currently required from: Dmitry Zhadinets, Peter Marheine.
Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/87341?usp=email )
Change subject: libflashrom: Add probing v2 which can find all mathching chips ......................................................................
Patch Set 5:
(3 comments)
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/87341/comment/7d0f8902_a4b2272b?usp... : PS3, Line 1216: if (ret == 1) {
I agree that it's worth having this branch, even if we know that the library currently never returns […]
Cool, thank you!
File include/libflashrom.h:
https://review.coreboot.org/c/flashrom/+/87341/comment/9fb7f377_c8576189?usp... : PS4, Line 312: const char **all_matched_names,
The tricky part is that you end up needing a three-star pointer. […]
I ended up with `const char *** const` :D which is by itself allocated and freed by the caller, and then the list of chips is allocated during probing, and freed by the caller. Tell me if it looks fine - or if this looks like what you were thinking about?
https://review.coreboot.org/c/flashrom/+/87341/comment/f24f1ff1_ef2a8c78?usp... : PS4, Line 313: unsigned int *all_matched_count,
Yeah, I think changing the meaning of the return value is fine since this also changes the entire fu […]
Done
-
Anastasia Klimchuk (Code Review)