Attention is currently required from: Dmitry Zhadinets, Peter Marheine.

View Change

3 comments:

• File cli_classic.c:

  • Patch Set #3, Line 1216: if (ret == 1) {

    I agree that it's worth having this branch, even if we know that the library currently never returns […]

    Cool, thank you!

• File include/libflashrom.h:

  • Patch Set #4, Line 312: const char **all_matched_names,

    The tricky part is that you end up needing a three-star pointer. […]

    I ended up with `const char *** const` :D which is by itself allocated and freed by the caller,
    and then the list of chips is allocated during probing, and freed by the caller.
    Tell me if it looks fine - or if this looks like what you were thinking about?

  • Patch Set #4, Line 313: unsigned int *all_matched_count,

    Yeah, I think changing the meaning of the return value is fine since this also changes the entire fu […]

    Done

To view, visit change 87341. To unsubscribe, or for help writing mail filters, visit settings.